Add commands to access template, template parts and styles #51501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +1.55 kB (0%) Total Size: 1.4 MB
ℹ️ View Unchanged
|
We should rename this to "Open Library" 
|
I'd be fine with using "Open" here too. "Open Templates" perhaps. |
|
And while we're at it, can we add the other two commands, for "Open Pages" and "Open Navigation"? That would give us coverage for each of the top-level nav items: 
|
Let's go ahead and add them as contextual for the top-level Site Editor. I think we should have a couple in every instance. At least templates and library perhaps. |
Another thought. I wonder if we should use "Open Style Variations" — as that's all we have there currently. Open Styles is a bit generic. |
|
Possibly unrelated, but when you load a custom created template and press ⌘K, the suggested action that also has focus is "Delete template": 
I don't think we should ever suggest a destructive action, they seem better to intentionally bury. So you can still search for them. |
|
I added the two remaining menus as commands. I've also updated the labels following the suggestions and made all these commands contextual too. |
|
Would love an approval on this one, to move to something else. @jasmussen That's because the "delete" and "revert customization" are both marked as "contextual commands". I can change that easily (probably in its own PR for clarity) |
richtabor
approved these changes
Jun 15, 2023
These won't be so front-and-center when we have more contextual commands. |
sethrubenstein
pushed a commit
to pewresearch/gutenberg
that referenced
this pull request
Jul 13, 2023
…#51501) * Add commands to access template, template parts and styles * Add more navigation commands * Fix icons
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #50407
What?
This PR just starts the work to add more commands to the command center. As it stands the PR adds:
Notes:
Testing Instructions
1- Open either the site or post editors
2- Type "Open styles" or "View templates" or "View template parts" to try these commands.